schannel: enforce Extended Key Usage for custom CA roots#21629
Closed
vszakats wants to merge 1 commit into
Closed
Conversation
Reported-by: Joshua Rogers (Aisle Research)
There was a problem hiding this comment.
Pull request overview
Enforces the Server Authentication Extended Key Usage (EKU) when building the certificate chain in the Schannel backend, so that custom CA roots cannot be misused for server-auth purposes without the proper EKU.
Changes:
- Initialize
CERT_CHAIN_PARA.RequestedUsagewithUSAGE_MATCH_TYPE_ANDand theszOID_PKIX_KP_SERVER_AUTHOID before callingCertGetCertificateChain.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jay
approved these changes
May 16, 2026
outcast36
pushed a commit
to greearb/curl
that referenced
this pull request
Jun 3, 2026
Reported-by: Joshua Rogers (Aisle Research) Closes curl#21629
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported-by: Joshua Rogers (Aisle Research)