cookie: trim trailing dots when checking PSL#21636
Closed
bagder wants to merge 2 commits into
Closed
Conversation
Verified with test 1629
There was a problem hiding this comment.
Pull request overview
This PR adjusts cookie Public Suffix List (PSL) handling so domain comparisons ignore a trailing dot, and adds a regression test to cover cookies set for a PSL domain with a trailing dot.
Changes:
- Trim a single trailing
.from the request host and cookie Domain before performing the libpsl acceptability check. - Add a new test (1629) for cookies using
Domain=co.uk.and hosts likefoo.co.uk.. - Register the new test in the tests data makefile.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/data/test1629 | Adds a regression test for cookie + PSL behavior with trailing-dot domains/hosts. |
| tests/data/Makefile.am | Includes the new test1629 in the test data list. |
| lib/cookie.c | Normalizes trailing-dot domains before calling libpsl cookie acceptability checks. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
outcast36
pushed a commit
to greearb/curl
that referenced
this pull request
Jun 3, 2026
Verified with test 1629 Closes curl#21636
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verified with test 1629