tidy-up: miscellaneous#21646
Conversation
|
this title and description don't explain what this PR is about, only who brought the complaint. |
|
I'm aware, yes. It's a temporary title, wanted to make it pass CI first. (edit: with Code Quality fixes there is some rush involved, because |
|
We ask everyone to describe their PRs. I think it is prudent of us maintainers to lead by example. So even if it takes 12 extra seconds, please use a title that explains it somewhat. Many people see and read the PRs as shown, so it is a courtesy to all those readers. |
|
I'm not yet sure what the title will be, it may be multiple PRs. CQ reports |
|
I'm sorry, I certainly don't mean to be harsh. I wanted to make a gentle reminder. |
vszakats
changed the title
|
no worries, probably one should not be looking at the CQ page in a hurry anyway. Maybe exporting the current report page as text could help. |
vszakats
changed the title
|
Catching this up again after moving some groups of fixes to other PRs, and adding a bunch more misc small fixes. |
"Lines 244-245 overwrite global variables `$runnerr` and `$runnerw` that were already assigned in the child process (lines 205-206). In the parent process context, these assignments appear incorrect and could cause issues if `runner_init` is called multiple times. The parent should only store references in the controller hashes." It could never cause an actual issue, but clarifies the intent of the code. Spotted and fixed by GitHub Code Quality Cherry-picked from #21646 Closes #21672
- replace `goto` with `while` loop. - fix newlines in a warning message. - handle open error for `curl/curlver.h` header. Ref: curl#21646 Closes curl#21670
After this patch `://` schemes are lowercase and enclosed in backticks. Also: - docs/libcurl/libcurl-multi.md: drop a stray C code fence. - docs/libcurl/libcurl-tutorial.md: replace single/double quotes with Markdown markup where applicable. Ref: curl#21646 Closes curl#21674
- fix typos and wording in documentation and comments. - KNOWN_BUGS: merge duplicate H1 section. - test_10_proxy: delete stray expressions. - Perl: `while()` -> `while(1)`. - Perl: fix indent, whitespace, drop redundant quotes and parentheses. - fix casing: URL, SSL, Windows. - badwords: readd `threadsafe`, add `well-known` (and fix it). - replace `WinXP` -> `Windows XP` to match other uses. Closes curl#21646
"Lines 244-245 overwrite global variables `$runnerr` and `$runnerw` that were already assigned in the child process (lines 205-206). In the parent process context, these assignments appear incorrect and could cause issues if `runner_init` is called multiple times. The parent should only store references in the controller hashes." It could never cause an actual issue, but clarifies the intent of the code. Spotted and fixed by GitHub Code Quality Cherry-picked from curl#21646 Closes curl#21672
2 participants
while()→while(1).threadsafe, addwell-known(and fix it).WinXP->Windows XPto match other uses.