connect: remove deref of freed pointer in trace call#21649
Closed
bagder wants to merge 1 commit into
Closed
Conversation
Spotted by CodeSonar
There was a problem hiding this comment.
Pull request overview
Fixes a use-after-free in a trace call within cf_setup_connect(): when Curl_cf_socks_proxy_insert_after() fails, dest may have been freed, so the original code dereferencing dest->hostname/dest->port in CURL_TRC_CF before the error check was unsafe. The error path now logs without touching dest and returns immediately.
Changes:
- On failure of adding the SOCKS filter, log without dereferencing
destand return early. - The success path retains the detailed trace using
dest->hostnameanddest->port.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
outcast36
pushed a commit
to greearb/curl
that referenced
this pull request
Jun 3, 2026
Spotted by CodeSonar Closes curl#21649
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spotted by CodeSonar