url: remove superfluous check#21650
Closed
bagder wants to merge 1 commit into
Closed
Conversation
This pointer is already verified to be non-NULL some 15 lines above. Pointed out by CodeSonar
There was a problem hiding this comment.
Pull request overview
This PR simplifies override_login() in lib/url.c by removing a redundant data->state.creds NULL-check inside a block that already guards on if(data->state.creds).
Changes:
- Removed an inner
else if(data->state.creds)condition and replaced it with a plainelsewithin theCREDS_URLhandling path. - Keeps behavior identical while eliminating dead/duplicated control flow flagged by static analysis.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
outcast36
pushed a commit
to greearb/curl
that referenced
this pull request
Jun 3, 2026
This pointer is already verified to be non-NULL some 15 lines above. Pointed out by CodeSonar Closes curl#21650
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pointer is already verified to be non-NULL some 15 lines above.
Pointed out by CodeSonar