vtls_scache: include signature_algorithms in the SSL peer cache key#21651
Closed
eslerm wants to merge 1 commit into
Closed
vtls_scache: include signature_algorithms in the SSL peer cache key#21651eslerm wants to merge 1 commit into
eslerm wants to merge 1 commit into
Conversation
Curl_ssl_peer_key_make() omitted ssl->signature_algorithms, although match_ssl_primary_config() compares the field. Two handles differing only in CURLOPT_SSL_SIGNATURE_ALGORITHMS therefore shared a peer key and could resume each other's sessions across a shared CURLSH SSL session cache. Add :SIGALGS-%s next to the other ssl_primary_config fields.
icing
approved these changes
May 18, 2026
Member
|
Thanks! |
outcast36
pushed a commit
to greearb/curl
that referenced
this pull request
Jun 3, 2026
Curl_ssl_peer_key_make() omitted ssl->signature_algorithms, although match_ssl_primary_config() compares the field. Two handles differing only in CURLOPT_SSL_SIGNATURE_ALGORITHMS therefore shared a peer key and could resume each other's sessions across a shared CURLSH SSL session cache. Add :SIGALGS-%s next to the other ssl_primary_config fields. Closes curl#21651
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Curl_ssl_peer_key_make() did not include ssl->signature_algorithms in
the SSL peer cache key, while match_ssl_primary_config() compares the
field. Handles differing only in CURLOPT_SSL_SIGNATURE_ALGORITHMS
shared a peer key and could resume each other's sessions across a
shared CURLSH SSL session cache.
Add :SIGALGS-%s alongside CIPHER13 and CURVES.
Verified on Linux (ubuntu:24.04, distro OpenSSL) and macOS (Homebrew
OpenSSL 3.6.2) that pre-patch reproduces the bypass and post-patch
returns rc=35.