vtls: use Curl_safecmp for CRLfile and pinned_key comparison#21668
Closed
MegaManSec wants to merge 1 commit into
Closed
vtls: use Curl_safecmp for CRLfile and pinned_key comparison#21668MegaManSec wants to merge 1 commit into
MegaManSec wants to merge 1 commit into
Conversation
Both are filesystem paths (or case-sensitive hash strings for pinned_key). curl_strequal is case-insensitive and would treat /etc/ssl/Crl.pem and /etc/ssl/crl.pem as the same file, unlike the other path fields (CApath, CAfile, issuercert, clientcert) which already use Curl_safecmp.
bagder
approved these changes
May 19, 2026
outcast36
pushed a commit
to greearb/curl
that referenced
this pull request
Jun 3, 2026
Both are filesystem paths (or case-sensitive hash strings for pinned_key). curl_strequal is case-insensitive and would treat /etc/ssl/Crl.pem and /etc/ssl/crl.pem as the same file, unlike the other path fields (CApath, CAfile, issuercert, clientcert) which already use Curl_safecmp. Closes curl#21668
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both are filesystem paths (or case-sensitive hash strings for pinned_key). curl_strequal is case-insensitive and would treat /etc/ssl/Crl.pem and /etc/ssl/crl.pem as the same file, unlike the other path fields (CApath, CAfile, issuercert, clientcert) which already use Curl_safecmp.