tests: add an assert to avoid IPC blocking#21688
Closed
dfandrich wants to merge 1 commit into
Closed
Conversation
If so much data is being sent over the internal IPC pipe that the pipe buffer fills and the syscall blocks, the program will hang. Add an assert to ensure that this limit is never reached. The buffer size is going to be different on different platforms, so choose 1KB which is likely to be a reasonable lower bound on just about any system. Currently, the maximum amount ever written is <100 bytes, so this should provide plenty of headroom. Spotted by Codex Security Closes #21688
bagder
approved these changes
May 20, 2026
vszakats
approved these changes
May 20, 2026
outcast36
pushed a commit
to greearb/curl
that referenced
this pull request
Jun 3, 2026
If so much data is being sent over the internal IPC pipe that the pipe buffer fills and the syscall blocks, the program will hang. Add an assert to ensure that this limit is never reached. The buffer size is going to be different on different platforms, so choose 1KB which is likely to be a reasonable lower bound on just about any system. Currently, the maximum amount ever written is <100 bytes, so this should provide plenty of headroom. Spotted by Codex Security Closes curl#21688
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If so much data is being sent over the internal IPC pipe that the pipe
buffer fills and the syscall blocks, the program will hang. Add an
assert to ensure that this limit is never reached. The buffer size is
going to be different on different platforms, so choose 1KB which is
likely to be a reasonable lower bound on just about any system.
Currently, the maximum amount ever written is <100 bytes, so this should
provide plenty of headroom.
Spotted by Codex Security
Closes #21688