ngtcp2: fail handshake directly#21712
Closed
icing wants to merge 2 commits into
Closed
Conversation
When certificate verification fails, error out of the handshake callback, forcing ngtcp2 to stop processing the connection any further.
bagder
approved these changes
May 21, 2026
There was a problem hiding this comment.
Pull request overview
This PR changes the ngtcp2 HTTP/3 backend to abort QUIC processing immediately when TLS peer verification fails by failing out of the handshake-completed callback, and by consistently surfacing the stored verification error back to the caller.
Changes:
- Return
NGTCP2_ERR_CALLBACK_FAILUREfromcf_ngtcp2_handshake_completed()whenCurl_vquic_tls_verify_peer()fails. - Propagate
ctx->tls_vrfy_resultas the effectiveCURLcoderesult fromcf_ngtcp2_recv(),cf_ngtcp2_send(), andcf_ngtcp2_connect()when set.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
outcast36
pushed a commit
to greearb/curl
that referenced
this pull request
Jun 3, 2026
When certificate verification fails, error out of the handshake callback, forcing ngtcp2 to stop processing the connection any further. Closes curl#21712
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When certificate verification fails, error out of the handshake callback, forcing ngtcp2 to stop processing the connection any further.