urlapi: forbid '|' in host#21762
Closed
tiymat wants to merge 1 commit into
Closed
Conversation
bagder
approved these changes
May 27, 2026
There was a problem hiding this comment.
Pull request overview
Adds | to the deny-list of characters disallowed in hostnames by hostname_check() in the URL API, fixing issue #21744 where http://a|b/ was incorrectly accepted. Per RFC 3986, | is not valid in reg-name, IP-literal, or IPv4address.
Changes:
- Add
|to thestrcspndeny-list inhostname_check(). - Add a test case
https://exam|ple.netexpectingCURLUE_BAD_HOSTNAMEinlib1560.c.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/urlapi.c | Adds ` |
| tests/libtest/lib1560.c | Adds a test case verifying that ` |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
Thanks! |
outcast36
pushed a commit
to greearb/curl
that referenced
this pull request
Jun 3, 2026
dkarpov1970
pushed a commit
to dkarpov1970/curl
that referenced
this pull request
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21744
Added
|to the list of characters that cause an error inhostname_check, added a test to cover it.