pytest: re-enable test test_05_01 and test_05_02 for quiche 0.29.0+#21784
Closed
vszakats wants to merge 5 commits into
Closed
pytest: re-enable test test_05_01 and test_05_02 for quiche 0.29.0+#21784vszakats wants to merge 5 commits into
vszakats wants to merge 5 commits into
Conversation
Ref: cloudflare/quiche#2277 Ref: cloudflare/quiche#2278 Follow-up to 91b422d curl#20952 Follow-up to 1447842 curl#19916
vszakats
changed the title
This reverts commit e1d3090.
vszakats
changed the title
This reverts commit f686f02.
outcast36
pushed a commit
to greearb/curl
that referenced
this pull request
Jun 3, 2026
The upstream issue seems to have been fixed or mitigated in quiche v0.29.0. Though the original upstream report and patch remain open at the time of writing this. Ref: cloudflare/quiche#2277 Ref: cloudflare/quiche#2278 Follow-up to 252b82f curl#21730 Follow-up to 91b422d curl#20952 Follow-up to 1447842 curl#19916 Closes curl#21784
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upstream issue seems to have been fixed or mitigated in quiche
v0.29.0. Though the original upstream report and patch remain open at
the time of writing this.
Ref: cloudflare/quiche#2277
Ref: cloudflare/quiche#2278
Follow-up to 252b82f #21730
Follow-up to 91b422d #20952
Follow-up to 1447842 #19916
This was a flaky issue, but previously all bumps failed, and with 0.29.1
neither the automatic bump, nor this PR failed, which makes me think
this has indeed seen an upstream fix or mitigation.
test 05_02 still failed at 0.28.0:
https://github.com/curl/curl/actions/runs/23865652425/job/69583976618