tool_operhlp: avoid NULL to %s#21836
Closed
bagder wants to merge 2 commits into
Closed
Conversation
If the filename allocation fails. Reported-by: Gao Liyou Ref: #21825
There was a problem hiding this comment.
Pull request overview
This PR fixes a potential undefined-behavior case in the curl tool helper logic by ensuring a NULL pointer from a failed filename allocation is no longer formatted via %s in a warning message.
Changes:
- Introduce a
DEFAULT_FILENAMEconstant for the fallback remote filename. - Avoid passing a potentially-NULL
*filenameintowarnf()formatting by using the constant string directly.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
outcast36
pushed a commit
to greearb/curl
that referenced
this pull request
Jun 3, 2026
If the filename allocation fails. Reported-by: Gao Liyou Ref: curl#21825 Closes curl#21836
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the filename allocation fails.
Reported-by: Gao Liyou
Ref: #21825