tool_help: rectify a bad assert#21837
Closed
bagder wants to merge 1 commit into
Closed
Conversation
The condition was wrong, and now it also verifies 'tlen'. Reported-by: Gao Liyou Ref: #21825
There was a problem hiding this comment.
Pull request overview
This pull request fixes an incorrect debug-time bounds assertion in the tool help “manual scan” logic (src/tool_help.c) by requiring all relevant scan token lengths to fit within the rolling buffer, and additionally validating the trigger length (tlen) which is used by the rolling memmove() window.
Changes:
- Replace an incorrect
DEBUGASSERTcondition that used||with a correct&&check. - Extend the assertion to also verify
ctx->tlenfits withinctx->rbuf.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
outcast36
pushed a commit
to greearb/curl
that referenced
this pull request
Jun 3, 2026
The condition was wrong, and now it also verifies 'tlen'. Reported-by: Gao Liyou Ref: curl#21825 Closes curl#21837
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The condition was wrong, and now it also verifies 'tlen'.
Reported-by: Gao Liyou
Ref: #21825