os400sys: fix theoretical length overflows#21840
Closed
vszakats wants to merge 3 commits into
Closed
Conversation
When converting a `size_t` to `unsigned int`. Reported-by: Gao Liyou Ref: curl#21825
There was a problem hiding this comment.
Pull request overview
This PR addresses a theoretical integer truncation/overflow risk in the OS/400 GSSAPI ASCII wrapper when converting a size_t buffer length into an unsigned int for allocation and conversion.
Changes:
- Add a bounds check before casting
inp->length(size_t) tounsigned intinCurl_gss_init_sec_context_a. - Fail early when the input token length is too large to be safely represented/used with
unsigned int-based allocation and indexing.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bagder
reviewed
Jun 2, 2026
vszakats
changed the title
outcast36
pushed a commit
to greearb/curl
that referenced
this pull request
Jun 3, 2026
When converting a `size_t` to `unsigned int`. Another instance spotted by Copilot. Reported-by: Gao Liyou Ref: curl#21825 Closes curl#21840
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When converting a
size_ttounsigned int.Another instance spotted by Copilot.
Reported-by: Gao Liyou
Ref: #21825