gtls: minor fixes and improvements#21850
Closed
vszakats wants to merge 5 commits into
Closed
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refines the GnuTLS TLS backend error reporting and log message consistency, primarily around shared credentials creation and server certificate issuer verification.
Changes:
- Fix incorrect GnuTLS function name referenced in
Curl_gtls_shared_creds_create()failure message. - Simplify formatting in
gtls_verify_ocsp_status()by unfolding a wrappedgnutls_credentials_get()call. - Improve issuer-certificate handling in
Curl_gtls_verifyserver()by reportinggnutls_x509_crt_import()failures and including GnuTLS error strings on issuer-check failures.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
outcast36
pushed a commit
to greearb/curl
that referenced
this pull request
Jun 3, 2026
- fix GnuTLS function name reference in `Curl_gtls_shared_creds_create()`
error message.
Spotted by GitHub Code Quality.
- unfold a line.
- in `Curl_gtls_verifyserver()`:
- report the failure of `gnutls_x509_crt_import()`.
Spotted by GitHub Code Quality.
- fix a minor inconsistency in error strings.
- drop redundant NULL checks for `config->issuercert`.
Closes curl#21850
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Curl_gtls_shared_creds_create()error message.
Spotted by GitHub Code Quality.
Curl_gtls_verifyserver():gnutls_x509_crt_import().Spotted by GitHub Code Quality.
config->issuercert.