tests: add cookies feature to some tests#21858
Merged
Merged
Conversation
These fail without cookie support. Closes curl#21858
MarcelRaad
force-pushed
the
fix_cookie_tests
branch
from
98fc896 to
75a94f3
Compare
There was a problem hiding this comment.
Pull request overview
This PR updates curl’s test definitions to explicitly require cookie support for a few HTTP tests that depend on cookie handling, ensuring they get skipped (instead of failing) when curl is built with cookies disabled.
Changes:
- Add
cookiesto the<features>requirements fortests/data/test7. - Add
cookiesto the<features>requirements fortests/data/test2504. - Add
cookiesto the<features>requirements fortests/data/test2015(alongside existingproxy).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/data/test7 | Declares cookies as a required feature for a cookie/header-related HTTP test. |
| tests/data/test2504 | Declares cookies as a required feature for a cookie-related handle reuse test. |
| tests/data/test2015 | Adds cookies to required features for a cookie + proxy + redirect test. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bagder
approved these changes
Jun 3, 2026
outcast36
pushed a commit
to greearb/curl
that referenced
this pull request
Jun 3, 2026
These fail without cookie support. Closes curl#21858
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These fail without cookie support.
This fixes my autobuilds.