http: reject spurious CR bytes in headers#21882
Closed
bagder wants to merge 5 commits into
Closed
Conversation
Verified by test 2105
There was a problem hiding this comment.
Pull request overview
This PR hardens HTTP response header parsing by rejecting embedded carriage return (CR) bytes within header lines (except for the terminal CRLF), and adds a regression test to ensure such responses fail with CURLE_WEIRD_SERVER_REPLY (8).
Changes:
- Add an HTTP header validation step that fails the transfer if a CR byte appears within a header line (outside the final CRLF).
- Introduce new test case
test2105covering a response header containing a spurious CR byte. - Register
test2105in the test data makefile so it runs in the suite.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
lib/http.c |
Adds detection/rejection of spurious \r bytes in received header lines. |
tests/data/test2105 |
New regression test ensuring responses with embedded CR in headers fail with error code 8. |
tests/data/Makefile.am |
Includes test2105 in the TESTCASES list so it is executed. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dkarpov1970
pushed a commit
to dkarpov1970/curl
that referenced
this pull request
Jun 9, 2026
Verified by test 2105 Closes curl#21882
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verified by test 2105