ftplistparser: clear strings.target if not symlink#21884
Closed
bagder wants to merge 1 commit into
Closed
Conversation
When the struct is passed to the CURLOPT_CHUNK_BGN_FUNCTION callback, clear the pointer if the provided data is not a symlink.
There was a problem hiding this comment.
Pull request overview
This PR updates the FTP LIST parser’s population of struct curl_fileinfo so that strings.target is only set when the parsed entry is actually a symlink, matching the intended semantics for data exposed to CURLOPT_CHUNK_BGN_FUNCTION.
Changes:
- Gate
finfo->strings.targetassignment onfinfo->filetype == CURLFILETYPE_SYMLINK. - Prevent stale
symlink_targetoffsets from leaking a non-NULLstrings.targetpointer for non-symlink entries.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the struct is passed to the CURLOPT_CHUNK_BGN_FUNCTION callback, clear the pointer if the provided data is not a symlink.