CURLOPT_ERRORBUFFER.3: Clarify it may not be written to on error#2190
Closed
jay wants to merge 1 commit intocurl:masterfrom
Closed
CURLOPT_ERRORBUFFER.3: Clarify it may not be written to on error#2190jay wants to merge 1 commit intocurl:masterfrom
jay wants to merge 1 commit intocurl:masterfrom
Conversation
- Advise the user to set the error buffer to an empty string before each request. Bug: https://curl.haxx.se/mail/lib-2017-12/0068.html Reported-by: Martin Galvan
Member
Author
|
alternately we could change this in the library to zero it out before each request, but I'm concerned we may miss some error code since errors can happen anywhere |
bagder
approved these changes
Jan 15, 2018
Member
bagder
left a comment
bagder
left a comment
There was a problem hiding this comment.
I think this improves the documentation of how it currently works.
Member
Author
|
I'm going to back away from the |
Member
|
@jay: that will indeed be the most user-friendly approach! |
bagder
added a commit
that referenced
this pull request
Mar 12, 2018
To offer applications a more defined behavior, we clear the buffer as early as possible. Bug #2190
Member
|
See #2377 for a take at making it cleared early on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
request.
Bug: https://curl.haxx.se/mail/lib-2017-12/0068.html
Reported-by: Martin Galvan