Skip to content

/curl

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CURLOPT_ERRORBUFFER.3: Clarify it may not be written to on error #2190

Closed
wants to merge 1 commit into from
+7 −5

Conversation

@jay
Copy link
Member

commented Dec 23, 2017

  • Advise the user to set the error buffer to an empty string before each
    request.

Bug: https://curl.haxx.se/mail/lib-2017-12/0068.html
Reported-by: Martin Galvan
@jay
CURLOPT_ERRORBUFFER.3: Clarify it may not be written to on error 
- Advise the user to set the error buffer to an empty string before each
  request.

Bug: https://curl.haxx.se/mail/lib-2017-12/0068.html
Reported-by: Martin Galvan
Loading status checks…
0f911aa

@jay jay added the documentation label Dec 23, 2017

@jay

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Dec 23, 2017

alternately we could change this in the library to zero it out before each request, but I'm concerned we may miss some error code since errors can happen anywhere
@bagder
bagder approved these changes Jan 15, 2018
View changes
Copy link
Member

left a comment

I think this improves the documentation of how it currently works.
@jay

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Jan 17, 2018

I'm going to back away from the It's advised to set the error buffer to an empty string before each request.. Instead I think it seems practical that the library would zero it for the user on perform.
@bagder

This comment has been minimized.

Sign in to view
Copy link
Member

commented Jan 17, 2018

@jay: that will indeed be the most user-friendly approach!
bagder added a commit that referenced this pull request Mar 12, 2018
@bagder
curl_multi_add_handle: clear errorbuffer if set 
To offer applications a more defined behavior.

Bug #2190
Verified
This commit was signed with a verified signature.
bagder Daniel Stenberg
GPG key ID: 5CC908FDB71E12C2 Learn about signing commits
Loading status checks…
e07f362
@bagder bagder referenced this pull request Mar 12, 2018
Closed
bagder added a commit that referenced this pull request Mar 12, 2018
@bagder
curl_multi_add_handle/easy_perform: clear errorbuffer if set 
To offer applications a more defined behavior, we clear the buffer as
early as possible.

Bug #2190
Verified
This commit was signed with a verified signature.
bagder Daniel Stenberg
GPG key ID: 5CC908FDB71E12C2 Learn about signing commits
Loading status checks…
83f0ebf
@bagder

This comment has been minimized.

Sign in to view
Copy link
Member

commented Mar 12, 2018

See #2377 for a take at making it cleared early on.

@bagder bagder closed this in fb4f568 Mar 17, 2018

@jay jay deleted the jay:fix_doc_ERRORBUFFER branch Mar 17, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Jun 15, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bagder bagder

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
2 participants
@jay @bagder
You can’t perform that action at this time.