netrc: remember and check filename loaded#21903
Closed
icing wants to merge 3 commits into
Closed
Conversation
Remember the filename of a loaded netrc file to detect changed configurations in a reused easy handle.
bagder
reviewed
Jun 8, 2026
bagder
approved these changes
Jun 8, 2026
There was a problem hiding this comment.
Pull request overview
This PR updates curl’s netrc caching so a reused easy handle can detect when a different netrc filename is being scanned and (re)load the file accordingly, rather than reusing previously loaded contents blindly.
Changes:
- Clears the in-memory netrc buffer before (re)loading a netrc file.
- Tracks the loaded netrc filename in
store_netrcand reloads when the requested filename differs. - Initializes and frees the stored filename in
Curl_netrc_init()/Curl_netrc_cleanup().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remember the filename of a loaded netrc file to detect changed configurations in a reused easy handle.