cookie: tailmatch the domains for secure override#21910
Closed
bagder wants to merge 2 commits into
Closed
Conversation
If a SECURE cookie is set for a sub-domain (`example.com`) and is then attempted to get set again for more specific part of that domain (`www.example.com`) without the SECURE property, the second occurance should not be allowed. Reported-by: Trail of Bits Verified by test 3305
There was a problem hiding this comment.
Pull request overview
This PR tightens curl’s cookie handling to prevent a non-secure cookie set for a more specific hostname from overriding (“overlaying”) an existing SECURE cookie set for a broader domain, addressing a security report and adding a regression test.
Changes:
- Add new test case
test3305to reproduce/verify the secure-cookie override scenario. - Register
test3305in the test dataMakefile.am. - Update
lib/cookie.cdomain matching used by the secure-overlay prevention logic to use tail-matching.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
tests/data/test3305 |
Adds a regression test covering secure cookie vs. non-secure attempted override across domain specificity. |
tests/data/Makefile.am |
Includes the new test case in the test suite list. |
lib/cookie.c |
Adjusts domain matching logic involved in preventing non-secure cookies from overlaying existing secure cookies. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a SECURE cookie is set for a sub-domain (
example.com) and is then attempted to get set again for more specific part of that domain (www.example.com) without the SECURE property, the second occurance should not be allowed.Reported-by: Trail of Bits
Verified by test 3305