urlapi: URL decode hostname before IP address normalization#21918
Closed
bagder wants to merge 1 commit into
Closed
urlapi: URL decode hostname before IP address normalization#21918bagder wants to merge 1 commit into
bagder wants to merge 1 commit into
Conversation
With this, IPv6 addresses that end with '%25' with no following zone id are considered invalid. Extend test 1560 to verify Reported-by: Hem Parekh
There was a problem hiding this comment.
Pull request overview
This PR updates curl’s URL parser to URL-decode the hostname earlier in authority parsing, so that percent-encoded IP literals (notably IPv6) are decoded before IP address normalization/validation. This makes bracketed IPv6 addresses ending in %25 with no following zone id be treated as invalid, and adds/adjusts unit tests to cover these cases.
Changes:
- Decode the authority host earlier (before IPv4/IPv6 normalization) in
parse_authority(). - Extend URL parsing tests to cover percent-encoded IPv4/IPv6 address forms and invalid zone-id edge cases.
- Update expected behavior so bracketed IPv6 ending with
%25and no zone id is rejected.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/urlapi.c | Decodes host before IP normalization so percent-encoded IP literals are validated correctly (including IPv6 zone-id edge cases). |
| tests/libtest/lib1560.c | Adds/updates URL parsing test vectors for percent-encoded IP literals and invalid IPv6 zone-id cases. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this, IPv6 addresses that end with '%25' with no following zone id are considered invalid.
Extend test 1560 to verify
Reported-by: Hem Parekh