AWS sigv4: refactor and URL encode username

[bagder]

No description provided.

[Copilot]

Pull request overview

This PR refactors the AWS SigV4 HTTP auth implementation and addresses header-injection risk by URL-encoding the SigV4 username used in the Credential= field.

Changes:

• Refactor Curl_output_aws_sigv4() into smaller helper functions for parameter parsing, payload hashing, timestamp generation, canonical request creation, and signing.
• URL-escape the SigV4 username before inserting it into the Authorization: header.
• Add a new regression test covering CRLF in the username and wire it into the test list.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
lib/http_aws_sigv4.c	Refactors SigV4 generation flow and URL-encodes the username used in the Authorization header.
tests/data/test3222	Adds a regression test ensuring CRLF in username is encoded in SigV4 Credential=.
tests/data/Makefile.am	Registers the new test case.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[bagder]

augment review

[augmentcode]

🤖 Augment PR Summary

Summary: Refactors the HTTP AWS SigV4 authentication implementation and hardens how the access key (username) is emitted in the generated Authorization header.

Changes:

• Split Curl_output_aws_sigv4() into focused helpers for parameter parsing, payload hashing, timestamp generation, canonical request construction, string-to-sign creation, and header signing/output.
• Percent-encode the SigV4 credential “username” when composing the Authorization: header to avoid embedding raw control characters.
• Preserve existing behavior for deriving service/region from the hostname when not explicitly provided.
• Keep S3-specific handling for x-*-content-sha256 and UNSIGNED-PAYLOAD behavior, while centralizing payload-hash selection.
• Update test metadata keywords to include aws-sigv4 for existing SigV4-related tests.
• Add new test test3222 covering CRLF in the username and verifying the resulting Authorization header contains an encoded credential.
• Register the new test in tests/data/Makefile.am.

Technical Notes: The change is primarily a refactor plus a safety hardening: encoding the credential field prevents header injection if a username contains CR/LF, and the new test asserts the encoded output.

_{🤖 Was this summary useful? React with 👍 or 👎}

[augmentcode]

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.