tests/data/test16{29,45}: Add the keyword "--resolve"#21930
Closed
fabiankeil wants to merge 1 commit into
Closed
Conversation
Member
|
Is the intent to have all tests that use |
Member
|
I'd suggest the title: "test1629, 1645: add keyword |
Member
|
Here are test files that use |
... even though they use the curl option "--resolve". This makes it more convenient to choose or skip the tests. For example Privoxy's cts test framework relies on the "--resolve" keyword when executing the "upstream-tests" scenario to skip curl tests that aren't expected to work when the requests are made through Privoxy. While some of the modified tests are already skipped for other reasons through other means when testing Privoxy, it's good to be consistent.
f07aebf to
bb7b84b
Compare
Contributor
Author
|
Thanks for the reviews. Some of the tests that lack the "--resolve" keyword were already skipped for other reasons when executing Privoxy's cts framework but consistency is good so I've added the keyword to the other tests that lack it. |
bagder
approved these changes
Jun 11, 2026
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So the tests can be skipped automatically based on the keyword when executing Privoxy's cts tests.