Skip to content

tests/data/test16{29,45}: Add the keyword "--resolve"#21930

Closed
fabiankeil wants to merge 1 commit into
curl:masterfrom
fabiankeil:add-resolve-keyword
Closed

tests/data/test16{29,45}: Add the keyword "--resolve"#21930
fabiankeil wants to merge 1 commit into
curl:masterfrom
fabiankeil:add-resolve-keyword

Conversation

@fabiankeil

Copy link
Copy Markdown
Contributor

So the tests can be skipped automatically based on the keyword when executing Privoxy's cts tests.

@github-actions github-actions Bot added the tests label Jun 9, 2026
@bagder

bagder commented Jun 9, 2026

Copy link
Copy Markdown
Member

Is the intent to have all tests that use --resolve to have that mentioned as a keyword? There seems to be many more tests doing that.

@vszakats

vszakats commented Jun 9, 2026

Copy link
Copy Markdown
Member

I'd suggest the title: "test1629, 1645: add keyword --resolve" to expose these numbers to grep.

@bagder

bagder commented Jun 9, 2026

Copy link
Copy Markdown
Member

Here are test files that use --resolve only once, indicating that they don't have it listed as a keyword:

$ git grep -c -- --resolve -- tests/data/ | grep :1 | cut -d: -f1
tests/data/test1629
tests/data/test1645
tests/data/test1646
tests/data/test1966
tests/data/test2008
tests/data/test2500
tests/data/test2503
tests/data/test31
tests/data/test779
tests/data/test795

... even though they use the curl option "--resolve".

This makes it more convenient to choose or skip the tests.

For example Privoxy's cts test framework relies on the "--resolve"
keyword when executing the "upstream-tests" scenario to skip curl
tests that aren't expected to work when the requests are made through
Privoxy. While some of the modified tests are already skipped for
other reasons through other means when testing Privoxy, it's good to
be consistent.
@fabiankeil fabiankeil force-pushed the add-resolve-keyword branch from f07aebf to bb7b84b Compare June 10, 2026 06:17
@fabiankeil

Copy link
Copy Markdown
Contributor Author

Thanks for the reviews.

Some of the tests that lack the "--resolve" keyword were already skipped for other reasons when executing Privoxy's cts framework but consistency is good so I've added the keyword to the other tests that lack it.

@bagder bagder closed this in 244834d Jun 11, 2026
@bagder

bagder commented Jun 11, 2026

Copy link
Copy Markdown
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants