brotli: data at the end of content can be lost #2194
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Decoding loop implementation did not concern the case when all received data is consumed by Brotli decoder and the size of decoded data, internally hold by Brotli decoder, is greater than CURL_MAX_WRITE_SIZE value. For content with not encoded length greater than CURL_MAX_WRITE_SIZE this can result in the loss of data at the end of content.
|
You're perfectly right. Many thanks for fix. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decoding loop implementation did not concern the case when all received data is consumed by Brotli decoder and the size of decoded data, internally hold by Brotli decoder, is greater than CURL_MAX_WRITE_SIZE value. For content with not encoded length greater than CURL_MAX_WRITE_SIZE this can result in the loss of data at the end of content.
I am not sure if the test for bug fix is welcome. It is also tied to CURL_MAX_WRITE_SIZE being set to 16384 and makes no sense if this value is greater.