config2setopts: use default protocol properly

[bagder]

No description provided.

[Copilot]

Pull request overview

This PR adjusts how the curl tool derives the “active” protocol from a URL when --proto-default is set, aiming to ensure the default protocol is used (and scheme guessing is avoided) for schemeless URLs.

Changes:

• Update url_proto_and_rewrite() to use CURLU_NO_GUESS_SCHEME when --proto-default is provided.
• Update documentation for --proto-default to clarify that ipfs/ipns cannot be used as default protocols.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
src/config2setopts.c	Changes scheme extraction logic in url_proto_and_rewrite() when --proto-default is set.
docs/cmdline-opts/proto-default.md	Documents that ipfs/ipns cannot be used as default protocols.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[bagder]

augment review

[augmentcode]

🤖 Augment PR Summary

Summary: Adjusts curl tool URL scheme detection so --proto-default is applied as intended (use the requested default when the URL has no explicit scheme) while still honoring explicit schemes.

Changes:

• Update src/config2setopts.c:url_proto_and_rewrite() to avoid hostname-based scheme guessing when config->proto_default is set (use CURLU_NO_GUESS_SCHEME and fall back to the default protocol token when needed).
• Ensure explicit ipfs:///ipns:// URLs still go through the IPFS gateway rewrite path even when --proto-default is provided.
• Document that --proto-default expects a case-insensitive bare protocol name (no :// suffix) and that it cannot be set to ipfs/ipns.
• Add new testcases covering IPFS + --proto-default (test1724), SCP selection via --proto-default (test1725), and rejecting a ://-suffixed argument (test2036).

Technical Notes: The change continues to use proto_token() for stable pointer comparisons, and uses CURLU_NO_GUESS_SCHEME to treat guessed schemes as “no scheme” when a default protocol is requested.

_{🤖 Was this summary useful? React with 👍 or 👎}

[augmentcode]

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.