AmigaOS : curl_setup avoid explicit_bzero with clib2

[boingball]

clib2 defines NEWLIB after its system headers are included, but it does not provide explicit_bzero().

curl therefore selects the explicit_bzero() path and fails to build with m68k-amigaos-gcc:

In file included from curlx/strdup.c:24:
curlx/strdup.c: In function 'curlx_freezero':
../lib/curl_setup.h:1650:35: error: implicit declaration of function 'explicit_bzero' [-Werror=implicit-function-declaration]
 1650 | #define curlx_memzero(buf, size)  explicit_bzero(buf, size)
      |                                   ^~~~~~~~~~~~~~
curlx/strdup.c:115:5: note: in expansion of macro 'curlx_memzero'
  115 |     curlx_memzero(buf, size);
      |     ^~~~~~~~~~~~~

Excluding CLIB2 from the generic NEWLIB branch makes curl use its existing portable curlx_memzero() fallback.
The full AmigaOS build then completes successfully.

I've tested the following on Amiga OS 3.2.3 with this patch and latest build.

• HTTP and HTTPS transfers
• AmiSSL certificate handling
• redirects
• downloads and file output
• timeout handling with the expected exit code 28
• repeated execution with clean exits
• no crashes or regressions observed

Follow-up to 066478f #21598

[vszakats]

Thanks!

It still hurts we were forced to drop the Amiga jobs from CI,
because the toolchain disappearing from the interwebs. I
wish I made a copy (or found one somewhere).

[boingball]

Thanks!

It still hurts we were forced to drop the Amiga jobs from CI, because the toolchain disappearing from the interwebs. I wish I made a copy (or found one somewhere).

Bebbo moved the Amiga GCC Toolchain off github over to cordberg - https://codeberg.org/bebbo/amiga-gcc
and GCC v16 has been added to it.

There is also a fork of the prior git hub - before removal here - https://github.com/AmigaPorts/m68k-amigaos-gcc
Hopefully maybe these might help.

[vszakats]

Is there perhaps a place where the pre-built Linux binary package is available?
It went by this URL:
https://github.com/bebbo/amiga-gcc/releases/download/Mechen/amiga-gcc.tgz

(using the Windows toolchain would be an alternative in theory, but last
time I tried locally I failed miserably to make it work. I'd also expect perf
to be (much) lower than Linux. I had no luck with accessing this link just
now: http://franke.ms/download/setup-amiga-gcc.exe)

[boingball]

Is there perhaps a place where the pre-built Linux binary package is available? It went by this URL: https://github.com/bebbo/amiga-gcc/releases/download/Mechen/amiga-gcc.tgz

(using the Windows toolchain would be an alternative in theory, but last time I tried locally I failed miserably to make it work. I'd also expect perf to be (much) lower than Linux. I had no luck with accessing this link just now: http://franke.ms/download/setup-amiga-gcc.exe)

I've had a look around and it seems that bebbo is also hosting that pre-built file here
https://franke.ms/download/amiga-gcc.tgz

it seems to be GCC 6.5.0 - which maybe your CI was working off before.

If that's not helpful I can send a message to Bebbo to see if I can host the pre-built based off the newer GCC.

[vszakats]

Lovely, I see if I can fire up the CI job again. And possibly add caching to
not hammer Bebbo's server.

GCC 6.5.0 is fine, the job doubling as tests for an older GCC version is useful.
Though can be upgraded in a future step if it's useful for the platform, and
we have binaries.

[vszakats]

AmigaOS is in CI again, yay!: #21993

[boingball]

Excellent work @vszakats ! - glad I could help.