socks_sspi: store socks5_gssapi_enctype#22004
Closed
bagder wants to merge 3 commits into
Closed
Conversation
Store the unwrapped protection level in `conn->socks5_gssapi_enctype` to prevent the proxy from contuning unprotected. Matches the GSSAPI version of the code. Reported-by: Trail of Bits
There was a problem hiding this comment.
Pull request overview
This PR aligns the SOCKS5 SSPI (Windows SSPI) GSS-API negotiation path with the existing GSSAPI implementation by persisting the negotiated protection level on the connection, so later SOCKS5 handling can detect when protection was granted/required and avoid continuing without enforcing it.
Changes:
- Store the negotiated (unwrapped) SOCKS5 GSS-API protection level into
conn->socks5_gssapi_enctypein the SSPI encryption negotiation code.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Store the unwrapped protection level in
conn->socks5_gssapi_enctypeto prevent the proxy from contuning unprotected. Matches the GSSAPI version of the code.Reported-by: Trail of Bits