cmake/FindGSS: fix comment, adjust custom flavor property name#22013
Closed
vszakats wants to merge 2 commits into
Closed
cmake/FindGSS: fix comment, adjust custom flavor property name#22013vszakats wants to merge 2 commits into
vszakats wants to merge 2 commits into
Conversation
Follow-up to 8aeefd0 (subcommit) Follow-up to 16f073e curl#16973
vszakats
changed the title
vszakats
changed the title
There was a problem hiding this comment.
Pull request overview
This PR updates curl’s CMake GSSAPI integration to use a consistently spelled custom target property name, and corrects the related documentation comment in FindGSS.cmake.
Changes:
- Rename custom interface property from
INTERFACE_CURL_GSS_FLAVOURtoINTERFACE_CURL_GSS_FLAVOR. - Update the
CMakeLists.txtlookup to use the renamed property. - Fix/clarify the property name referenced in
CMake/FindGSS.cmake’s header comment.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| CMakeLists.txt | Reads the updated CURL::gss interface property name to determine GNU vs MIT behavior. |
| CMake/FindGSS.cmake | Sets and documents the corrected custom property name on the CURL::gss imported interface target. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
INTERFACE_CURL_GSS_FLAVOUR->INTERFACE_CURL_GSS_FLAVORto match preferred usage.Follow-up to 8aeefd0 (subcommit)
Follow-up to 16f073e #16973
https://github.com/curl/curl/pull/22013/files?w=1