src: sync nghttp2 versions checks with current requirements#22061
Closed
vszakats wants to merge 1 commit into
Closed
src: sync nghttp2 versions checks with current requirements#22061vszakats wants to merge 1 commit into
vszakats wants to merge 1 commit into
Conversation
Also: - drop a redundant check. - make the in-source error informative. Follow-up to 2900c29 curl#11473
vszakats
changed the title
There was a problem hiding this comment.
Pull request overview
This PR aligns libcurl’s in-source nghttp2 version requirement with the existing build-system requirement (nghttp2 ≥ 1.15.0), removes a now-redundant preprocessor guard, and makes the compile-time failure message more informative.
Changes:
- Bump the in-source minimum
NGHTTP2_VERSION_NUMcheck to0x010f00(nghttp2 1.15.0). - Drop the redundant conditional around
NGHTTP2_HAS_SET_LOCAL_WINDOW_SIZE. - Compact the nghttp2 1.50.0 option guard comment onto the
#ifline in both H2 client creation sites.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/http2.c | Updates the minimum nghttp2 version check to 1.15.0, improves the #error message, and removes a redundant feature-define guard. |
| lib/cf-h2-proxy.c | Minor preprocessor formatting change for the nghttp2 ≥ 1.50.0 option guard to match lib/http2.c. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also:
Follow-up to 2900c29 #11473