cmake/FindGSS: drop CMake <3.16 compatibility logic#22072
Closed
vszakats wants to merge 1 commit into
Closed
Conversation
Redundant since bumping minimum to 3.18. Follow-up to 89043ba curl#20407
There was a problem hiding this comment.
Pull request overview
This PR updates curl’s CMake GSS detection helper to remove legacy compatibility logic for CMake versions older than 3.16, aligning the module with the project-wide minimum CMake requirement (3.18).
Changes:
- Simplify the pkg-config detection branch in
FindGSS.cmakeby relying solely on_gss_MODULE_NAME. - Remove the fallback check for the undocumented
_pkg_check_modules_pkg_namevariable used for older CMake versions.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redundant since bumping minimum to 3.18.
Follow-up to 89043ba #20407
Follow-up to 1f11224 #18950