Skip to content

CURLMOPT_SOCKETFUNCTION.md: this sends *all* file descriptors#22081

Closed
bagder wants to merge 6 commits into
masterfrom
bagder/socketfunc-sockets
Closed

CURLMOPT_SOCKETFUNCTION.md: this sends *all* file descriptors#22081
bagder wants to merge 6 commits into
masterfrom
bagder/socketfunc-sockets

Conversation

@bagder

@bagder bagder commented Jun 18, 2026

Copy link
Copy Markdown
Member

Since libcurl has more than just the main transfer sockets to worry about.

Since libcurl has more than just the main tranfer sockets to worry
about.
@bagder bagder marked this pull request as ready for review June 18, 2026 12:56
@bagder bagder requested a review from Copilot June 18, 2026 12:56

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the CURLMOPT_SOCKETFUNCTION(3) documentation to clarify that the socket callback can be invoked for more than just “main transfer” sockets, including additional internal file descriptors libcurl uses.

Changes:

  • Reformat the SYNOPSIS prototype for readability (argument names and line wrapping).
  • Clarify callback behavior/wording and emphasize that libcurl may pass internal FDs (resolver, Happy Eyeballs, etc.) to the socket callback.
  • Expand CURL_POLL_REMOVE semantics to note it may not imply immediate close, and mention the curl_multi_assign(3) association is dropped when a socket is removed.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docs/libcurl/opts/CURLMOPT_SOCKETFUNCTION.md Outdated
different casing

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Comment thread docs/libcurl/opts/CURLMOPT_SOCKETFUNCTION.md Outdated
@testclutch

Copy link
Copy Markdown

Analysis of PR #22081 at a1e099eb:

Test 1275 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Note that this test has failed in 382 different CI jobs (the link just goes to one of them).

Test 3017 failed, but it has been 60.7% flaky lately, so it's probably NOT a fault of the PR. Note that this test has failed in 4 different CI jobs (the link just goes to one of them). Note that this CI job has had a number of other flaky tests recently (2, to be specific) so it may be that this failure is rather a systemic issue with this job and not with this specific PR.

Generated by Testclutch

@bagder bagder closed this in b71d3d9 Jun 18, 2026
@bagder bagder deleted the bagder/socketfunc-sockets branch June 18, 2026 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants