Skip to content

openssl: do not mix OpenSSL int result with CURLcode variable#22087

Closed
vszakats wants to merge 1 commit into
curl:masterfrom
vszakats:ossl-fixup
Closed

openssl: do not mix OpenSSL int result with CURLcode variable#22087
vszakats wants to merge 1 commit into
curl:masterfrom
vszakats:ossl-fixup

Conversation

@vszakats

@vszakats vszakats commented Jun 18, 2026

Copy link
Copy Markdown
Member

Seen with clang-22:

lib/vtls/openssl.c:3538:14: error: implicit conversion from 'int' to enumeration type 'CURLcode' is invalid in C++ [-Werror,-Wimplicit-int-enum-cast]
 3538 |     result = SSL_ech_set1_server_names(octx->ssl,
      |            ~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 3539 |                                        peer->origin->hostname, outername,
      |                                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 3540 |                                        0 /* do send outer */);
      |                                        ~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

Ref: https://github.com/curl/curl/actions/runs/27769068896/job/82163712258#step:42:43

Cherry-picked from #22086

@vszakats vszakats changed the title openssl: do not mix OpenSSL int result with CURLcode variable openssl: do not mix OpenSSL int result with CURLcode variable Jun 18, 2026
@vszakats vszakats closed this in 39628c5 Jun 18, 2026
@vszakats vszakats deleted the ossl-fixup branch June 18, 2026 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants