runtests: drop orphaned, no-op -k option#22100
Closed
vszakats wants to merge 1 commit into
Closed
Conversation
And the corresponding internal variable. Reported-by: Zartaj Majeed Ref: curl#22098 Follow-up to 6617db6 curl#4035
Contributor
|
After this, |
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Jun 24, 2026
Dropped `-k` for tests as it was removed upstream in 04305a3e40989d3731e97bd0ef41bbd55c680a3f, though it seemed to manifest in a strange way with the test runner exiting 0 but not running (m?)any tests. I've mentioned it on the relevant PR. Bug: curl/curl#22100 Bug: https://bugs.gentoo.org/978006 Signed-off-by: Sam James <sam@gentoo.org>
1 task
vszakats
added a commit
that referenced
this pull request
Jun 25, 2026
Restore processing this option to avoid falling it through and misinterpreted as something else, which in turn disables tests. Exit with an error instead. We delete completely in December 2026. Reported-by: Sam James Bug: #22100 (comment) Follow-up to 04305a3 #22100 Follow-up to 6617db6 #4035 Closes #22157
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And the corresponding internal variable.
This option became the always-enabled default earlier, via #4035.
Reported-by: Zartaj Majeed
Ref: #22098
Follow-up to 6617db6 #4035