doh: cap the maximum TTL to 24 hours#22122
Closed
bagder wants to merge 4 commits into
Closed
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a safety cap to DNS-over-HTTPS (DoH) decoded TTL values to avoid excessively large cache lifetimes (whether due to misconfiguration or abuse), aligning behavior with common public DNS resolver practices.
Changes:
- Introduces a maximum TTL cap of 24 hours for DoH-decoded responses.
- Applies the cap during response decoding before selecting the minimum TTL across answers.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
To avoid mistakes or abuse to cause problems. Many public DNS provides cap their cache times to this.
unsigned Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To avoid mistakes or abuse to cause problems. Many public DNS providers cap their cache times to this.