doh: stricter HTTPS RR parsing#22124
Closed
bagder wants to merge 2 commits into
Closed
Conversation
If the target RDATA field tries to use compression, abort. If any sublabel is longer than 63 octets, abort. Reported-by: netspacer.research
There was a problem hiding this comment.
Pull request overview
Tightens DoH HTTPS RR (RFC 9460) target-name parsing to reject compressed names and overly long labels, improving robustness against malformed RDATA.
Changes:
- Renames the target hostname length constant to
CURL_MAXLEN_HOST_NAME. - Rejects HTTPS RR target RDATA that attempts DNS name compression.
- Adds rejection for sublabels longer than 63 bytes (but currently only for subsequent labels).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lib/httpsrr.h | Renames the hostname-length macro to an all-caps variant. |
| lib/doh.c | Adds stricter HTTPS RR target-name decoding checks (compression + label-length validation). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the target RDATA field tries to use compression, abort.
If any sublabel is longer than 63 octets, abort.
Reported-by: netspacer.research