scripts: use end-of-options marker in cd, mkdir, mv, sha256sum commands#22150
scripts: use end-of-options marker in cd, mkdir, mv, sha256sum commands#22150vszakats wants to merge 52 commits into
cd, mkdir, mv, sha256sum commands#22150Conversation
|
NB -- to end arguments is not POSIX, so this will cause breakage on some systems.
|
I suspect it may be an issue for Then there is The others seem fine, as they are CI/developer/internal. |
-- before passing variable argumentscd, cp, mkdir, mv, rm commands
|
After review, there is just one case left in Makefile.am, The rest is much reduced, in most cases to I'll move out not stritcly related updates to separate |
This reverts commit b27979a. I'm not grokking how this works, but this simplification did not. TODO: read up on: https://www.gnu.org/software/automake/manual/html_node/Clean.html
DISTCLEANFILES are supposed to cover stuff created by configure, and these files are not like that. https://www.gnu.org/software/automake/manual/html_node/Clean.html
|
Turns out the remaining |
cd, cp, mkdir, mv, rm commandscd, cp, mkdir, mv, sha256sum commands
cd, cp, mkdir, mv, sha256sum commandscd, mkdir, mv, sha256sum commands
- Makefile.am: add root `test-quiet` target that maps to `tests/quiet-test`, for completeness. Ref: #22098 - tests/Makefile.am: drop unused remains of `MANFILES`. Follow-up to fa3f889 #17463 Also replace the `distclean` target to delete `CLEANFILES`, otherwise the CI dist job fails. (I'm not grokking why) - tests/Makefile.am: sync up `tests` target with CMake, to pass `TFLAGS` `-a`. Follow-up to 904e7ec #19347 - tests/certs/Makefile.am: fix to clean generated certs via `CLEANFILES` to comply with autotools documentation, which says the previously used variable `DISTCLEANFILES` is meant for files created by `./configure`. Ref: https://www.gnu.org/software/automake/manual/html_node/Clean.html Follow-up to 44341e7 #16824 - tests/http/Makefile.am: add `./` prefix to glob passed to `rm -rf` on clean, to avoid deleting unintented files, or pass unintended options. Follow-up to 6711582 #10349 Cherry-picked from #22102 Cherry-picked from #22150 Closes #22154
Where missing. To avoid passing an option by accident.
End-of-option marker (
--) is not POSIX, but most of these scripts areinternal and/or CI-focused, where this is fine.
maketgzandverify-releaseare meant for public use, and I asses this is fine too,but let us know if this causes issues in real world envs.
Also:
:?torm -rf, where missing.Cannot cause an actual issue with current code.
cp,rminstances too, but none were affected.$PWDwith$(pwd)for sturdiness.$PWDwith$(pwd)for sturdiness.Assisted-by: Dan Fandrich
Follow-up to 6aab1dc #19450
esp Makefile.am, maketgz and verify-release.
--is necessary/useful in thecd -- "$(dirname "$0")"command.MANFILES.move to #22154:
MANFILES.Follow-up to fa3f889 tests: move test docs into /docs #17463
CLEANFILES. [WIP]./prefix to glob passed torm -rf.