cmake: flatten build tree, tidy up base dir variables#22192
Closed
vszakats wants to merge 4 commits into
Closed
Conversation
To avoid crearing a CMake subdir within the build dir with this single file in it. To move it next to its cmake_install.cmake counterparth To move it next to install_manifest.txt which it relies on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
drop
generatedsubdir, move these files to build root.To move them next to CPack and other config files, and to avoid
a subdirectory for only 2 files.
Follow-up to 6932849 CMake: Improve config installation #2849
add 'Consumed variables' comment for
CMake/cmake_uninstall.in.cmake.move generated
cmake_uninstall.cmaketo the build root directory(from
CMake/). To:CMakesubdirectory within the build directorywith this single file in it.
cmake_install.cmakecounterpart.install_manifest.txtwhich it relies on.Follow-up to 27e2a47
Use
PROJECT_SOURCE_DIRfor these files, replacingCMAKE_CURRENT_SOURCE_DIR, to make it consistent with rest of CMakesources, and to reduce ambiguity in
CMake/cmake_uninstall.in.cmaketemplate.
Follow-up to 8198e38 #22188
Follow-up to 4839029 #22187
Follow-up to 9126eb5 #15331
Note: the
ninja curl_uninstallfeature does not work in certain cases.It also does not remove empty directories.