cmake: dedupe expressions into local vars in cmake_uninstall.in.cmake#22194
Closed
vszakats wants to merge 4 commits into
Closed
cmake: dedupe expressions into local vars in cmake_uninstall.in.cmake#22194vszakats wants to merge 4 commits into
cmake_uninstall.in.cmake#22194vszakats wants to merge 4 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors the CMake uninstall script template (CMake/cmake_uninstall.in.cmake) to reduce repeated expressions and use more idiomatic CMake list iteration, improving readability while preserving behavior.
Changes:
- Introduces a local
_manifestvariable for theinstall_manifest.txtpath and reuses it for existence checks and reading. - Switches
foreach(_file ...)toforeach(_file IN LISTS _files)after converting the manifest content into a semicolon-separated list. - Introduces a
_targetlocal variable for$ENV{DESTDIR}${_file}to deduplicate repeated path expressions and simplify log/remove statements.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also: use
IN LISTSsyntax.Follow-up to 27e2a47