openssl: drop unused pre-OpenSSL3 ctx_option_t typedef#22197
Closed
vszakats wants to merge 1 commit into
Closed
Conversation
There was a problem hiding this comment.
Pull request overview
Removes the now-obsolete pre-OpenSSL 3 ctx_option_t fallback and simplifies the OpenSSL backend’s option-mask typedef selection, consistent with curl’s OpenSSL 3.0+ minimum (except for LibreSSL/BoringSSL-like backends).
Changes:
- Reworks
ctx_option_ttypedef selection to prioritize LibreSSL, then BoringSSL-like, and otherwise default to a 64-bit option type. - Drops the pre-OpenSSL 3
unsigned longfallback (no longer reachable under the enforced OpenSSL 3.0+ minimum).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vszakats
changed the title
ctx_option_t typectx_option_t typedef
vszakats
added a commit
that referenced
this pull request
Jun 26, 2026
By exposing and reusing existing custom type via `vtls/openss.h`.
Also:
- GHA/curl-for-win: test in CI by enabling building tests.
Cost is 45s per job, so limit it to the gcc job.
Seen with Windows x64 gcc (not tested in CI prior to this patch):
```
tests/libtest/lib1587.c:50:7: error: conversion from 'opt1587' {aka 'long long unsigned int'} to 'long int' may change value [-Werror=conversion]
50 | SSL_CTX_set_options(info->internals, opts);
| ^~~~~~~~~~~~~~~~~~~
tests/libtest/lib1587.c:59:7: error: conversion from 'opt1587' {aka 'long long unsigned int'} to 'long int' may change value [-Werror=conversion]
59 | SSL_set_options(info->internals, opts);
| ^~~~~~~~~~~~~~~
```
Ref: https://github.com/curl/curl/actions/runs/28258372229/job/83727170184?pr=22195#step:3:4884
Ref: da2f05e #22198
Ref: 6163566 #22197
Follow-up to 3e40ccb #21290
Follow-up to 2db8ae4 #17809 #17801
Closes #22195
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to 69c89bf #18330