Skip to content

CURLOPT_SSH_*_KEYFILE: used for setting up, then no more#22211

Closed
bagder wants to merge 2 commits into
masterfrom
bagder/ssh-keys-reuse
Closed

CURLOPT_SSH_*_KEYFILE: used for setting up, then no more#22211
bagder wants to merge 2 commits into
masterfrom
bagder/ssh-keys-reuse

Conversation

@bagder

@bagder bagder commented Jun 29, 2026

Copy link
Copy Markdown
Member

So changing them after the connection is made still allows libcurl to reuse the existing connections.

So changing them after the connection is made still allows libcurl to
reuse the existing connections.
@bagder bagder requested a review from Copilot June 29, 2026 06:09
@bagder bagder marked this pull request as ready for review June 29, 2026 06:09

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates libcurl SSH keyfile option documentation to clarify that CURLOPT_SSH_PUBLIC_KEYFILE and CURLOPT_SSH_PRIVATE_KEYFILE are only consulted when establishing a new SSH connection, and that changing these options after a connection is established does not prevent libcurl from reusing an already-vetted connection.

Changes:

  • Document that CURLOPT_SSH_PUBLIC_KEYFILE is used only during new SSH connection setup; established connections may be reused even if the option changes.
  • Document the same “setup-only” semantics for CURLOPT_SSH_PRIVATE_KEYFILE.
  • Minor formatting adjustment in the private keyfile option text.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
docs/libcurl/opts/CURLOPT_SSH_PUBLIC_KEYFILE.md Adds clarification that the public keyfile option is only used when setting up new SSH connections and does not affect reuse of already-established connections.
docs/libcurl/opts/CURLOPT_SSH_PRIVATE_KEYFILE.md Adds the same connection-setup-only clarification for the private keyfile option and tweaks a paragraph’s formatting.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docs/libcurl/opts/CURLOPT_SSH_PUBLIC_KEYFILE.md Outdated
Comment thread docs/libcurl/opts/CURLOPT_SSH_PRIVATE_KEYFILE.md Outdated
word polish

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@bagder bagder closed this in f3c1169 Jun 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants