CURLOPT_SSH_*_KEYFILE: used for setting up, then no more#22211
Closed
bagder wants to merge 2 commits into
Closed
Conversation
So changing them after the connection is made still allows libcurl to reuse the existing connections.
There was a problem hiding this comment.
Pull request overview
Updates libcurl SSH keyfile option documentation to clarify that CURLOPT_SSH_PUBLIC_KEYFILE and CURLOPT_SSH_PRIVATE_KEYFILE are only consulted when establishing a new SSH connection, and that changing these options after a connection is established does not prevent libcurl from reusing an already-vetted connection.
Changes:
- Document that
CURLOPT_SSH_PUBLIC_KEYFILEis used only during new SSH connection setup; established connections may be reused even if the option changes. - Document the same “setup-only” semantics for
CURLOPT_SSH_PRIVATE_KEYFILE. - Minor formatting adjustment in the private keyfile option text.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| docs/libcurl/opts/CURLOPT_SSH_PUBLIC_KEYFILE.md | Adds clarification that the public keyfile option is only used when setting up new SSH connections and does not affect reuse of already-established connections. |
| docs/libcurl/opts/CURLOPT_SSH_PRIVATE_KEYFILE.md | Adds the same connection-setup-only clarification for the private keyfile option and tweaks a paragraph’s formatting. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
word polish Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So changing them after the connection is made still allows libcurl to reuse the existing connections.