mbedtls: replace memset() with psa_hash_operation_init()#22220
Closed
vszakats wants to merge 1 commit into
Closed
Conversation
To initialize hash contexts.
There was a problem hiding this comment.
Pull request overview
This PR updates the mbedTLS+PSA-backed MD5 and SHA-256 implementations to initialize psa_hash_operation_t contexts using psa_hash_operation_init() instead of zeroing memory with memset(), aligning initialization with the PSA Crypto API’s intended usage.
Changes:
- In
lib/sha256.c, replacememset()initialization withpsa_hash_operation_init()before callingpsa_hash_setup(). - In
lib/md5.c, replacememset()initialization withpsa_hash_operation_init()before callingpsa_hash_setup().
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/sha256.c | Switch PSA SHA-256 context initialization from memset() to psa_hash_operation_init(). |
| lib/md5.c | Switch PSA MD5 context initialization from memset() to psa_hash_operation_init(). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To initialize hash contexts.
Ref: https://arm-software.github.io/psa-api/crypto/1.1/api/ops/hashes.html#c.psa_hash_operation_init
Follow-up to 3a30583 #19077