vquic: add Curl_ prefix to some global functions - #22254
Closed
bagder wants to merge 3 commits into
Closed
Conversation
There was a problem hiding this comment.
Pull request overview
This PR standardizes internal vquic (HTTP/3/QUIC) helper symbols by adding the Curl_ prefix to a set of previously unprefixed global functions/types, reducing the chance of global symbol collisions and aligning with libcurl internal naming patterns.
Changes:
- Renamed several
vquic_*global helper functions toCurl_vquic_*in the vquic implementation and internal header. - Updated vquic callers across the quiche and ngtcp2 backends to use the new names.
- Renamed the packet-receive callback typedef and the HTTP/3 error-to-string helper to use the
Curl_prefix.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| lib/vquic/vquic.c | Renames vquic global helpers to Curl_vquic_* and updates internal call sites. |
| lib/vquic/vquic_int.h | Updates internal declarations/macros/typedefs to match the new Curl_vquic_* names. |
| lib/vquic/cf-quiche.c | Updates quiche backend to call renamed vquic helpers. |
| lib/vquic/cf-ngtcp2.c | Updates ngtcp2 backend to call renamed vquic helpers. |
| lib/vquic/cf-ngtcp2-proxy.c | Updates proxy code path to use renamed HTTP/3 error string helper. |
| lib/vquic/cf-ngtcp2-cmn.c | Updates common ngtcp2 code to call renamed vquic helpers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.