Enhance terminal size detection for multiple outputs - #22276
Conversation
|
Analysis of PR #22276 at c8aabda4: Test 311 failed, but it has been 2.1% flaky lately, so it's probably NOT a fault of the PR. Note that this test has failed in 12 different CI jobs (the link just goes to one of them). Generated by Testclutch |
|
If retrieving the terminal size via stdin is a problem because of redirect, then that could also be true of stdout, stderr etc, |
|
also why does it say |
|
The reporter seems to be MIA on this but I think it's probably a good idea to get terminal columns from stderr , stdout etc if stdin isn't a terminal. @bagder is there a reason you chose stdin, did it seem most likely, or do you have any objection to this change? |
bagder
left a comment
There was a problem hiding this comment.
Looks good, assuming the minor nits are addressed.
Sorry, I can't recall why I selected stdin for this! |
- Get the terminal size from STDOUT or STDERR when the terminal size of STDIN is not available. Closes curl#22276
|
Despite no response from the author I've landed this with everyone's suggested changes. |
Added additional checks for terminal size using STDERR and STDOUT.