test1560: allow to build and run without LDAP support - #22312
Closed
bagder wants to merge 1 commit into
Closed
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates curl’s URL API unit test 1560 so it can still be built and executed in configurations where LDAP protocol support is compiled out.
Changes:
- Conditionally compile LDAP-related
CURLU_GUESS_SCHEMEtest vectors inlib1560.cbehind#ifndef CURL_DISABLE_LDAP. - Remove
ldapfrom the required<features>list fortests/data/test1560so the test is no longer skipped purely due to missing LDAP support.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/libtest/lib1560.c | Wraps LDAP guess-scheme test cases with #ifndef CURL_DISABLE_LDAP to avoid exercising LDAP expectations when LDAP is disabled. |
| tests/data/test1560 | Drops ldap from required features so the test can run on non-LDAP builds. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.