ngtcp2: let verify failures win over expiry processing errors - #22317
Closed
GrahamCampbell wants to merge 1 commit into
Closed
ngtcp2: let verify failures win over expiry processing errors#22317GrahamCampbell wants to merge 1 commit into
GrahamCampbell wants to merge 1 commit into
Conversation
icing
approved these changes
Jul 14, 2026
Member
|
Thanks, merged now! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A flaky CI failure of
test_17_05_bad_ip_addr[h3](GnuTLS, event-based) had curl detect the certificate name mismatch yet exit withCURLE_RECV_ERROR(56) instead ofCURLE_PEER_FAILED_VERIFICATION(60).Curl_cf_ngtcp2_cmn_connectcallsCurl_cf_ngtcp2_cmn_set_expiryafter itsctx->tls_vrfy_resultoverride and returns the error unfiltered, so when the server's final handshake flight happens to be processed by the ingress inside set_expiry, the verify failure surfaces as a generic receive error.This PR makes set_expiry prefer
ctx->tls_vrfy_resultover generic progress errors, as the recv and send paths already do after calling it, and also covers thecf-ngtcp2-proxy.ccall sites that lack the override. Completes #21712. Seen in https://github.com/curl/curl/actions/runs/29243256619/job/86794119412.