test798: force IPv4 to avoid cross-runner port aliasing - #22318
Closed
GrahamCampbell wants to merge 1 commit into
Closed
test798: force IPv4 to avoid cross-runner port aliasing#22318GrahamCampbell wants to merge 1 commit into
GrahamCampbell wants to merge 1 commit into
Conversation
bagder
approved these changes
Jul 14, 2026
Member
|
Merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test798is the only test fetchinghttp://localhost:%HTTPPORTwithout-4, since it needs the hostname for its foldeddomain=localhostcookie. curl tries::1first, but the test HTTP server is IPv4-only. On the BSDs, IPv4 and IPv6 have separate ephemeral port namespaces, so with every test server binding port 0, another parallel runner's IPv6-bound server can hold the same numeric port. curl then connects to the wrong runner's server, which cannot open its ownlog/N/test798and closes without a response, giving exit 52 and an emptyserver.input.This PR fixes this flake by adding
-4matches what tests 389 and 392 already do. Linux is immune because wildcard IPv6 binds occupy the IPv4 port too. Seen in https://github.com/curl/curl/actions/runs/29229170329/job/86749470571.