quiche: set the max field section size - #22331
Closed
GrahamCampbell wants to merge 1 commit into
Closed
Conversation
2 tasks
Member
|
I believe this function was introduced in quiche 0.20.0 so maybe, with this change, we should document that as the earliest supported quiche version? I just noticed that we don't yet list a version in docs/INTERNALS.md. |
vszakats
approved these changes
Jul 15, 2026
Member
|
PR #22333 to document the requirement. |
vszakats
added a commit
that referenced
this pull request
Jul 15, 2026
For function `quiche_h3_config_set_max_field_section_size()`. Ref: #22331 Ref: #22331 (comment) Ref: https://github.com/cloudflare/quiche/releases/tag/0.20.0 Closes #22333
Contributor
Author
|
Sounds good. The max 2 PR rule limits me from marking this as ready for review, so we'll need to wait until some of my other PRs ahead of this one are merged/closed first. :) |
Member
|
Ah ok, I merged it now, thanks for the PR! |
vszakats
pushed a commit
that referenced
this pull request
Jul 15, 2026
Member
Let me bump the limit, it was arbitrarily set anyway! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
quiche 0.29.3 started enforcing a default
SETTINGS_MAX_FIELD_SECTION_SIZEof 32KB, so larger response headers now shut down the whole connection withCURLE_HTTP3. curl accepts up to 300KB of response headers with every other backend and HTTP version. Tell quiche to allow what curl itself allows. This keeps test_01_11 passing with quiche 0.29.3 and it also advertises our real limit to servers, which the RFC encourages.