uint-spbset: reuse empty chunks - #22340
Closed
icing wants to merge 1 commit into
Closed
Conversation
Fix chunk allocations by reusing existing empty chunks when a new offset is needed. Before this fix, spbsets would only ever grow with added numbers outside the range of existing chunks.
icing
changed the title
bagder
approved these changes
Jul 20, 2026
There was a problem hiding this comment.
Pull request overview
This PR improves the uint32_spbset sparse bitset implementation by reusing existing empty chunks when growing the set to cover a new offset, avoiding unnecessary allocations and preventing spbsets from only ever growing when values move across offset ranges.
Changes:
- Add helpers to detect and detach reusable empty chunks, and to insert chunks into the ordered chunk list.
- Update chunk lookup/creation to preferentially reuse empty chunks before allocating new ones.
- Simplify per-chunk indexing arithmetic in add/remove/contains.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix chunk allocations by reusing existing empty chunks when a new offset is needed. Before this fix, spbsets would only ever grow with added numbers outside the range of existing chunks.