/curl

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mime: duplicate mime tree upon easy handle duplication. #2235

Closed
wants to merge 3 commits into
from

Conversation

Reviewers

@bagder bagder

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@monnerat @bagder
@monnerat
Collaborator

monnerat commented Jan 14, 2018

A mime tree attached to an easy handle using CURLOPT_MIMEPOST is
strongly bound to the handle: there is a pointer to the easy handle in
each item of the mime tree and following the parent pointer list
of mime items ends in a dummy part stored within the handle.

Because of this binding, a mime tree cannot be shared between different
easy handles, thus it needs to be cloned upon easy handle duplication.

There is no way for the caller to get the duplicated mime tree
handle: it is then set to be automatically destroyed upon freeing the
new easy handle.

New test 654 checks proper mime structure duplication/release.

Add a warning note in curl_mime_data_cb() documentation about sharing
user data between duplicated handles.

monnerat added some commits Jan 14, 2018

@monnerat
mime: duplicate mime tree upon easy handle duplication. 
A mime tree attached to an easy handle using CURLOPT_MIMEPOST is
strongly bound to the handle: there is a pointer to the easy handle in
each item of the mime tree and following the parent pointer list
of mime items ends in a dummy part stored within the handle.

Because of this binding, a mime tree cannot be shared between different
easy handles, thus it needs to be cloned upon easy handle duplication.

There is no way for the caller to get the duplicated mime tree
handle: it is then set to be automatically destroyed upon freeing the
new easy handle.

New test 654 checks proper mime structure duplication/release.

Add a warning note in curl_mime_data_cb() documentation about sharing
user data between duplicated handles.
Loading status checks…
a80b2c6
@monnerat
mime: explicitly convert memory data size to size_t.
Loading status checks…
e6e1335
@bagder

bagder approved these changes Jan 14, 2018
View changes

@monnerat

This comment has been minimized.

Show comment
Hide comment
@monnerat

monnerat Jan 14, 2018

Collaborator

@bagder: thanks for review + approval. I will fix a few things and improve code coverage on this PR before pushing to master.
Collaborator

monnerat commented Jan 14, 2018

@bagder: thanks for review + approval. I will fix a few things and improve code coverage on this PR before pushing to master.
@monnerat
mime: fixes for mime tree duplication. 
Duplicate encoder too.
Do not fail duplication if a file is not readable.

Improve mime tree duplication code coverage from test654.
Loading status checks…
65afd7f

@monnerat monnerat closed this in e44ddfd Jan 14, 2018

@lock lock bot locked as resolved and limited conversation to collaborators May 9, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.